Minecraft从自定义药水效果中添加新药水效果

Question

当前正在尝试创建一个药水效果，一旦时间用完，将其他药水效果应用到玩家身上。看起来很简单,但我发现了一些错误和bug,

直接尝试添加效果

    @Override
    public void performEffect(EntityLivingBase entity, int amplifier){
        if (entity instanceof EntityPlayer)
        {
            EntityPlayer player = (EntityPlayer)entity;
            if(player != null){
                if(player.getActivePotionEffect(PotionRegistry.effectBuzz) != null){
                int duraction = player.getActivePotionEffect(PotionRegistry.effectBuzz).getDuration();
                    if(duration <= 2){
                        player.addPotionEffect(new PotionEffect(MobEffects.WEAKNESS, 1200));
                    }
                }
            }
        }
    }

不用说，这会产生这个错误

[16:10:04][服务器线程/错误]:遇到意外异常Net.Minecraft.util.ReportedException：在Net.Minecraft.Network.NetworkSystem.NetworkTick（NetworkSystem.java:212)~[NetworkSystem.Class：？]在Net.Minecraft.Server.MinecraftServer.UpdateTimeLightAndEntities(MinecraftServer.java:807)~[MinecraftServer.Class：？]在Net.Minecraft.Server.MinecraftServer.Tick（MinecraftServer.java:688)~[MinecraftServer.Class：？]在Net.Minecraft.Server.Integrated.IntegratedServer.Tick(IntegratedServer.java:156)~[IntegratedServer.Class：？]在Net.Minecraft.Server.MinecraftServer.Run（MinecraftServer.java:537)[MinecraftServer.Class：？]在java.lang.Thread.Run（未知源）[？：1.8.0_161]由：java.util.HashMap$Hashiterator.NextNode（未知源）导致的：java.util.HashMap$Keyiterator.Next（未知源）~[？：1.8.0_161]在net.minecraft.Entity.EntityLivingBase.UpdatePotionEffects（EntityLivingBase.java:650)~[EntityLivingBase.Class：？]在Net.Minecraft.Entity.EntityLivingBase.OnEntityUpdate（EntityLivingBase.java:383)~[EntityLivingBase.Class：？]在Net.Minecraft.Entity.Entity.OnUpdate（Entity.java:436)~[Entity.Class：？]在Net.Minecraft.Entity.EntityLivingBase.OnUpdate（EntityLivingBase.java:2144)~[EntityLivingBase.Class：？]在Net.Minecraft.Entity.Player.EntityPlayer.OnUpdate（EntityPlayer.java:260)~[EntityPlayer.Class：？]在Net.Minecraft.Entity.Player.EntityPlayerMP.OnUpdateEntity（EntityPlayerMP.java:345)~[EntityPlayerMP.Class：？]在Net.Minecraft.Network.NetHandlerPlayServer.Update(NetHandlerPlayServer.java:174)~[NetHandlerPlayServer.Class：？]在net.minecraftforge.fml.common.network.handshake.networkdispatcher$1.update（networkdispatcher.java:216)~[networkdispatcher$1.class：？]在Net.Minecraft.Network.NetworkManager.ProcessReceivedPackets（NetworkManager.java:309)~[NetworkManager.Class：？]在net.minecraft.network.networksystem.networktick（networksystem.java:197)~[networksystem.class：？]...又有5个

好像我在一个tick事件中运行这个

在CommonProxy中

MinecraftForge.EVENT_BUS.register(new EventManager());

然后对EventManager本身

public class EventManager {

public static PotionEffect potion = new PotionEffect(MobEffects.WEAKNESS, 1200);
public static PotionEffect potion2 = new PotionEffect(MobEffects.HUNGER, 600);
public static PotionEffect potion3 = new PotionEffect(MobEffects.UNLUCK, 1200);

@SubscribeEvent
public void onTick(WorldTickEvent event){
    EntityPlayer player = Minecraft.getMinecraft().thePlayer;
    World world = Minecraft.getMinecraft().theWorld;
    if(player != null){
        boolean hasEffect = player.isPotionActive(PotionRegistry.effectBuzz);
        int applyIt = 0;

        if(hasEffect){
            applyIt = 1;
        } else if(!player.isPotionActive(potion.getPotion()) && applyIt == 1){
            applyIt = 2;
        } else {
            applyIt = 0;
        }

        if(player != null && applyIt == 2){
            player.addPotionEffect(potion);
        }
    }
}

}

这是可行的，但效果是无限的。

Answer 1

你正在执行你的行动，同时药水的效果正在循环。这类似于在迭代数组时修改数组。别那么做。

另外，不要执行类似药水效果客户端的操作。客户端要做的唯一事情是图形和用户输入/输出。

像药水这样的事情必须在服务器上处理，否则服务器会在下一个更新数据包上覆盖您的操作。

只需在ExtendPlayer实体中设置一个标志，然后onTick或player update事件检查该标志是否存在，然后添加药水。

@Override
public void performEffect(EntityLivingBase entity, int amplifier){
    if (entity instanceof EntityPlayer)
    {
        EntityPlayer player = (EntityPlayer)entity;
        if(player != null){
            if(player.getActivePotionEffect(PotionRegistry.effectBuzz) != null){
            int duraction = player.getActivePotionEffect(PotionRegistry.effectBuzz).getDuration();
                if(duration <= 2){
                    ExtendedPlayer ePlayer = ExtendedPlayer.get(player);
                    ePlayer.enableBuzz();
                }
            }
        }
    }
}

类似于扩展播放机的东西

public class ExtendedPlayer implements IExtendedEntityProperties {

     ... Extended player setup here

     protected boolean startBuzz = false;

     public void enableBuzz() 
     {
          this.startBuzz = true;
     }
     public static final ExtendedPlayer get(EntityPlayer player) {
        return (ExtendedPlayer) player.getExtendedProperties("MuddymansExtendedPlayer");
    }

    public EntityPlayer getPlayer() {
        return this.player;
    }

    /**
    * Updates anything that needs to be updated each tick
    * NOT called automatically, so you must call it yourself from LivingUpdateEvent or a TickHandler
    */
    public void onUpdate() {
        if(!player.worldObj.isRemote) {
            if(this.enableBuzz) {
                Player player = this.getPlayer()
                player.addPotionEffect(new PotionEffect(MobEffects.WEAKNESS, 1200));
                player.addPotionEffect(new PotionEffect(MobEffects.HUNGER, 600));
                player.addPotionEffect(new PotionEffect(MobEffects.UNLUCK, 1200));
                this.startBuzz = false;
            }
        }
    } 
}

从事件处理程序调用exteded播放机更新事件

 @SubscribeEvent
 public void livingTick(final LivingUpdateEvent event) {
        if (event.entity != null && event.entity instanceof EntityPlayer) {
            if(!event.entity.isDead) {
                ExtendedPlayer.get((EntityPlayer)event.entity).onUpdate();
            }
        }