Check4在java中的游戏错误是谁赢了，因为结果只是随机地替换，而不是当有人赢了时

Question

我做了一个check4的游戏，用户放置一个坐标，检查被下降到设置x坐标的底部。球员轮流，直到一个球员达到4个检查在一个连续，无论是水平，垂直或对角醇。这个游戏工作得很好，但出于某种原因，我不能让胜利者的方法正常工作。这并不是说它不起作用，我只是不能让比赛以正确的理由获胜，这似乎很随机。Ex-It不会打印__won，当X或O在一个行中得到4时，而是在游戏的随机会话中打印。

package lab_A;

import java.util.Arrays;
import java.util.Scanner;

public class Connect4_ex
{

    public static void main(String[] args)
    {
        Board();
    }

    public static void Board()
    {
        
        char turn = 'O';
        boolean win = false;

        char[][] board = new char[6][7];
        int k = 0;
        int z = 0;

        for(int i=0;i<6;i++)
        {
            for(int j=0;j<7;j++)
            {
                board[i][j] = ' ';
            }
        }

        do {
            if(k%2 == 1)
            {
                Scanner scan = new Scanner(System.in);
                System.out.println("enter x check");
                int x = scan.nextInt();
                System.out.println("enter y check");
                int y = scan.nextInt();

                if( x > 0 && x < 8 && board[0][x-1]==' ' && y > 0 && y < 7)
                {
                    int free;
                    for(free=0;free<6;free++){
                        if(board[free][x-1]!=' ') break;
                    }
                    board[free-1][x-1]='X';
                    System.out.println("Board : \n" + Arrays.deepToString(board).replace("], ", "]\n "));
                    k++;
                }else{
                    System.out.println("your check is out of bounds");
                }
            }

            if(k%2 == 0)
            {
                Scanner scan = new Scanner(System.in);
                System.out.println("enter x check");
                int x = scan.nextInt();
                System.out.println("enter y check");
                int y = scan.nextInt();

                if( x > 0 && x < 8 && board[0][x-1]==' ' && y > 0 && y < 7)
                {
                    int free;
                    for(free=0;free<6;free++){
                        if(board[free][x-1]!=' ') break;
                    }
                    board[free-1][x-1]='O';
                    System.out.println("Board : \n" + Arrays.deepToString(board).replace("], ", "]\n "));
                    k++;
                }else{
                    System.out.println("your check is out of bounds");
                }
                
                
            }
            
            win = Winner(turn,board);
            
            if(turn == 'O') {
                turn = 'X';
            }else {
                turn = 'O';
            }
            
        }while(win == false);
        

        if(win) {
            if(turn =='O') {
                System.out.println("O won");
            }else {
                System.out.println("X won");
            }   
        }else {
            System.out.println("game is a Tie");
        }
                
    }
        
        public static boolean Winner(char turn, char[][] board){
            

            for(int i = 0; i<board.length; i++){
                for (int j = 0;j < board[0].length - 3;j++){
                    if (board[i][j] == turn   && 
                        board[i][j+1] == turn &&
                        board[i][j+2] == turn &&
                        board[i][j+3] == turn){
                        return true;
                    }
                }           
            }

            for(int i = 0; i < board.length - 3; i++){
                for(int j = 0; j < board[0].length; j++){
                    if (board[i][j] == turn   && 
                        board[i+1][j] == turn &&
                        board[i+2][j] == turn &&
                        board[i+3][j] == turn){
                        return true;
                    }
                }
            }

            for(int i = 3; i < board.length; i++){
                for(int j = 0; j < board[0].length - 3; j++){
                    if (board[i][j] == turn   && 
                        board[i-1][j+1] == turn &&
                        board[i-2][j+2] == turn &&
                        board[i-3][j+3] == turn){
                        return true;
                    }
                }
            }
            
            for(int i = 0; i < board.length - 3; i++){
                for(int j = 0; j < board[0].length - 3; j++){
                    if (board[i][j] == turn   && 
                        board[i+1][j+1] == turn &&
                        board[i+2][j+2] == turn &&
                        board[i+3][j+3] == turn){
                        return true;
                    }
                }
            }
            return false;
        }
    
        
  }

Answer 1

您有两个问题和一个奇怪（关于游戏）：

问题

1. k变量在k%2==1大小写中递增，这意味着k%2==0大小写在当前循环中执行，这意味着它永远不会在轮到x时检查获胜者。
2. 当声明获胜者(win为true）时，代码立即更改turn，然后跳出循环并声明另一个玩家为获胜者。

null

// if the "is odd" check fails then it must be even so just use else.
else // was if(k%2 == 0)
{
   //... continue
}

if (!win) {
    if(turn == 'O') {
        turn = 'X';
    }else {
        turn = 'O';
    }
}

建议的改进：

1. 扫描输入的两个代码块之间唯一的区别是设置移动到当前玩家的一行。使其成为一个单独的方法，并传入播放器(char)并返回k:

拉出方法：

 // Validate move and update board and return true if valid.
 public static boolean applyMove(int x, char turn, char board[][]);

并像这样使用它：

if (applyMove(x,turn,board)) {
   k++;
}