我想要一些建议来清理一系列if语句

Question

我有一个方法，它做了相当多的验证，它正在发展失控。如果有任何关于如何最好地清理这种方法的建议，我将不胜感激。我使用的是Java 11，这个方法是spring boot微服务的一部分。

public void validateRequest(DepositRequest depositRequest, String transferId, String userId) {
    if (!Arrays.asList("REALTIME_PAYMENT", "ACCOUNT_PAYMENT").contains(depositRequest.creditTransfer()
            .getTransferInformation().getValue())) {
        logError(depositRequest, participantUserId, etransferId, INVALID_ACCOUNT_NUMBER);
        throw new ServerValidationException(INVALID_ACCOUNT_NUMBER, PAYMENT);
    }

    if (depositRequest.creditTransfer().getGroupHeader().getSettlementInformation().getClearingSystem() == null) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "proprietary");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
    }

    if (depositRequest.creditTransfer().getGroupHeader().getInstructing()
            .getInstitutionIdentification().getMemberIdentification() == null) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "member_identification");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
    }

    if (depositRequest.creditTransfer().getGroupHeader().getInstructed()
            cialInstitutionIdentification().getMemberIdentification() == null) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "member_identification");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
    }

    if (depositRequest.creditTransfer().getTransferInformation().getCreditor().getName() == null) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "creditor.name");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
    }

    if (depositRequest.creditTransfer().getTransferInformation().getDebtor().getName() == null) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "debtor.name");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
    }

    if (depositRequest.authorization() != null) {
        if (depositRequest.authorization().getToken() == null ||
                authorization().getToken().length() < 1 ||
                authorization().getToken().length() > 35) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "participant_authorization_token");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
        }
    }

    if (!isCreditorAccountIdentificationValid(depositRequest.creditTransfer().getTransferInformation().getIdentification())) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "identification");
        throw new ServerValidationException(INVALID_ACCOUNT_INFO, PAYMENT);
    }

    if (!depositRequest.creditTransfer().getTransferInformation().getSettlementDate().equals(LocalDate.now())) {
        logSchemaValidationError(depositRequest, etransferId, participantUserId, "settlement_date");
        throw new ServerValidationException(SCHEMA_VALIDATION_ERROR, PAYMENT);
    }
}

Answer 1

简单的代码就是好代码。您当前的代码易于理解和维护。所以我不一定急于改变。但如果你愿意，你可以：

>

在一个单独的私有方法中执行每个验证，只需在主validate方法中调用每个方法

public void validateRequest(DepositRequest depositRequest, String transferId, String userId) {
 validateAccountNumber(depositRequest,transferId, userId);
    ...
}

private void validateAccountNumber(DepositRequest depositRequest, String transferId, String userId) {
    ...
}

您可以创建一个验证器接口

public interface Validator {
     void validate(DepositRequest depositRequest, String transferId, String userId);
}

public class AccountIDValidator implements Validator {
     public void validate(DepositRequest depositRequest, String transferId, String userId){
          ...
      }
 }

然后为每个验证创建此接口的实例，并将它们放在一个列表中，以便您的验证变成

   List<Validator> validators=Arrays.asList(new AccountIDValidator(),...);

   public void validateRequest(DepositRequest depositRequest, String transferId, String userId) {
       for (Validator v:validators){
          v.validate();
       }
   }

希望这有帮助！