Sonarint提示“重构代码以便使用流管道”

Question

我使用了一种基于流的方法来映射并减少我的列表

List<Map<String,String>> mailVariable = (List<Map<String, String>>) processVariables.get("MAIL_MAP");

1| List<CustomObject> detList = mailVariable
2|                                      .stream()
3|                                      .flatMap(getEntry)
4|                                      .filter (isEmpty)
5|                                      .reduce(new ArrayList<CustomObject>(),accumulateToCustomObject,combiner);

我正在使用sonarLint分析我的代码，并在第2行和第3行得到以下错误

重构此代码，以便使用流管道。鱿鱼：S3958

事实上，我正在使用stream并从这里建议的终端操作中返回值。我做错什么了吗？。有谁能建议正确的代码编写方法吗？

// following are the functional interface impls used in the process

Function<Map<String,String>, Stream<Entry<String,String>>> getEntry = data -> data.entrySet().stream();

Predicate<Entry<String, String>> isEmpty                            = data -> data.getValue() != null
                                                                                    || !data.getValue().isEmpty() 
                                                                                    || !data.getValue().equals(" ");

BinaryOperator<ArrayList<CustomObject>> combiner                = (a, b) -> {
                                                                                ArrayList<CustomObject> acc = b;
                                                                                acc.addAll(a);
                                                                                return acc;
                                                                            };

BiFunction<ArrayList<CustomObject>,Entry<String,String>,ArrayList<CustomObject>> accumulateToCustomObject = (finalList, eachset) -> {
                /* reduction process happens            
                   building the CustomObject..
                */
                return finalList;
            };




Answer 1

更新：：我找到了一个解决此问题的方法，将map reduce操作拆分为map和collect操作，如下所示。现在出现了特定的lint错误

List<AlertEventLogDetTO> detList = mailVariable
                                                    .stream()
                                                    .flatMap(getEntry)
                                                    .filter (isEmpty)
                                                    .map(mapToObj)
                                                    .filter(Objects::nonNull)
                                                    .collect(Collectors.toList());

Function<Entry<String,String>,AlertEventLogDetTO> mapToObj = eachSet -> {
                String tagString = null;
                String tagValue  = eachSet.getValue();

                try{
                    tagString = MapVariables.valueOf(eachSet.getKey()).getTag();
                } catch(Exception e){
                    tagString = eachSet.getKey();
                }

                if(eventTags.contains(tagString)){
                    AlertEventLogDetTO entity = new AlertEventLogDetTO();
                    entity.setAeldAelId(alertEventLog.getAelId());
                    entity.setAelTag(tagString);
                    entity.setAelValue(tagValue);

                    return entity;
                }

                return null;
            };