sonar显示，该方法可能无法清除已检查异常的流或资源

Question

public boolean isAuditTrailEnabled(String masterAccessId) 
{
    String selectQuery = "select t.audit_flag from PARAMETER_MENU_ATTRIBUTES t where t.access_id = '"+masterAccessId+"'";
    PreparedStatement preparedStmnt = null;
    ResultSet resultSet = null;
    String flag = "N";

        if(connection == null)
        {
            initConnection();
        }   
        try {
            **preparedStmnt = connection.prepareStatement(selectQuery);**
            resultSet = preparedStmnt.executeQuery();
            if(resultSet.next())
            {
                flag = resultSet.getString(1);
            }
        }
        catch (SQLException e) {

            try {
                if (resultSet != null){
                    resultSet.close();
                }
                if (preparedStmnt != null){
                    preparedStmnt.close();
                }

            } catch (SQLException e1) {

            }

            return true;
        }
        finally{
            try {
                if (resultSet != null){
                    resultSet.close();
                }
                if (preparedStmnt != null){
                    preparedStmnt.close();
                }
                cleanup();
            } catch (SQLException e1) {
                return false;
            }

        }
        if(flag.equals("N")){
            return false;
        }else{
            return true;
        }

}

它显示了这个特定声明的问题。你能帮帮我吗？

Answer 1

结果集和语句始终应在单独的try-catch中关闭。。。即使2不能这样写。。。如果。。。或者如果。。。。先检查基本情况

if(something)
   {
      if(something)
    }
or

if((something) &&(something))