使用@Newspan创建跨度时，不发送时间戳和持续时间

Question

我正在使用Spring Cloud Sleuth和Zipkin（通过HTTP），将spring-cloud-starter-zipkin版本2.0.0.M6添加到我的依赖项（基于Spring Boot 2.0.0.rc1和Spring Cloud Finchley M6)中。

我正在使用@Newspan注释来标记某个（昂贵的）操作的子跨度。当跨度信息发送到Zipkin时，我注意到缺少子跨度的时间戳和持续时间。这导致在Zipking侧的一个奇怪的渲染。但是，当我通过调用tracer#newchild创建子跨度时，它会像预期的那样工作。

我是不是漏掉了什么？这会是Sleuth 2.0.0.M6的问题吗？

当我使用Spring Boot1.5.9和Spring Cloud Edgware SR2运行相同的代码时，它的行为与预期的一样。

下面是在Zipkin端收到的JSON。名为“child-span-with-annotation”的span是使用@newspan创建的，而span“childspanwithnewchild”是使用跟踪器#newchild创建的。

[
  {
    "traceId": "b1c2636366c919be",
    "id": "b1c2636366c919be",
    "name": "get",
    "timestamp": 1518495271073166,
    "duration": 862032,
    "annotations": [
      {
        "timestamp": 1518495271073166,
        "value": "sr",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      },
      {
        "timestamp": 1518495271935198,
        "value": "ss",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "ca",
        "value": true,
        "endpoint": {
          "serviceName": "",
          "ipv6": "::1",
          "port": 51982
        }
      },
      {
        "key": "http.path",
        "value": "/hello",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      },
      {
        "key": "mvc.controller.class",
        "value": "MyRestController",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      },
      {
        "key": "mvc.controller.method",
        "value": "sayHello",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      }
    ]
  },
  {
    "traceId": "b1c2636366c919be",
    "id": "14be7ac6eafb0e01",
    "name": "child-span-with-annotation",
    "parentId": "b1c2636366c919be",
    "binaryAnnotations": [
      {
        "key": "class",
        "value": "MyService",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      },
      {
        "key": "method",
        "value": "expensiveOperation1",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      }
    ]
  },
  {
    "traceId": "b1c2636366c919be",
    "id": "b34a4f910f27fdb4",
    "name": "childspanwithnewchild",
    "parentId": "b1c2636366c919be",
    "timestamp": 1518495271479040,
    "duration": 453747,
    "binaryAnnotations": [
      {
        "key": "lc",
        "value": "",
        "endpoint": {
          "serviceName": "sample-sleuth-app",
          "ipv4": "---.---.---.---"
        }
      }
    ]
  }
]

Answer 1

这是一个bug-https://github.com/spring-cloud/spring-cloud-sleuth/issues/855。我把它修好了。一种解决方法是在每个使用@newspan的方法中手动启动它，方法是在当前跨度上调用start()方法（该方法缩放不太好）

@Autowired SpanCustomizer customizer;

@NewSpan
void foo() {
    this.customizer.start();
}

您还可以创建spanCreator的bean（您可以在这里检查固定版本https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/annotation/defaultspanCreator.java）

class MySpanCreator implements SpanCreator {

    private static final Log log = LogFactory.getLog(MySpanCreator.class);

    private final Tracing tracer;

    MySpanCreator(Tracing tracer) {
        this.tracer = tracer;
    }

    @Override public Span createSpan(MethodInvocation pjp, NewSpan newSpanAnnotation) {
        String name = StringUtils.isEmpty(newSpanAnnotation.name()) ?
                pjp.getMethod().getName() : newSpanAnnotation.name();
        String changedName = SpanNameUtil.toLowerHyphen(name);
        if (log.isDebugEnabled()) {
            log.debug("For the class [" + pjp.getThis().getClass() + "] method "
                    + "[" + pjp.getMethod().getName() + "] will name the span [" + changedName + "]");
        }
        return this.tracer.tracer().nextSpan().name(changedName).start();
    }

}

请注意方法末尾的.start()。