必须反复提交用户选择

Question

嘿，伙计们，在一个多部分的问题上遇到了一些麻烦。我试图得到一个石头剪刀布游戏，当我试图测试代码使用游戏方法我必须输入我的选择一遍又一遍，然后它只是打印出平局，你是赢家，电脑是赢家一遍又一遍，有人能告诉我我哪里出错了吗？

import java.util.Scanner;
import java.util.Random;
/**
 * A class that will play a game of rock paper scissors.
 *
 * @author (your name)
 * @version (a version number or a date)
 */

public class RockPaperScissors
{
    private Scanner reader;
    private int yourScore;
    private int computerScore;
    private Random ran = new Random();

    public RockPaperScissors()
    {
        reader = new Scanner(System.in);
        yourScore = 0;
        computerScore=0;
        Random ran = new Random(); 
    }

    public void printPrompt()
    {
        System.out.println("Enter your choice, paper, rock or scissors >"); 
        String userChoice = userChoice();
        System.out.println();
        System.out.println();
        System.out.println("Enter your choice, paper, rock or scissors  >"+ userChoice);
    }

    public final String userChoice()
    {
        String userChoice= reader.next();
        return userChoice;
    }

    public String computerChoice()
    {
        String compMove = ("");
        int cpuChoice = ran.nextInt(3);
        switch(cpuChoice)
        {
            case 0:
            {
                compMove = ("rock");
                break;
            }
            case 1:
            {
                compMove = ("paper");
                break;
            }
            case 2:
            {
                compMove = ("scissors");
                break;
            }

        }
        return (compMove);
    }

    public String findWinner(String yourChoice, String computerChoice) 
    {
        yourChoice = userChoice();
        computerChoice = computerChoice();
        String Winner= null;

        if (yourChoice.equals(computerChoice))
        {
            Winner = ("draw");
        }
        if (yourChoice.equals("rock")) 
        {
            if (computerChoice.equals("paper")) 
            {
                computerScore++;
                Winner = ("computer");

            }
            else if (computerChoice == "scissors")
            {
                yourScore++;
                Winner = ("you");

            }
        }
        if (yourChoice.equals("paper"))
        {
            if (computerChoice.equals("scissors"))
            {
                computerScore++;
                Winner = ("computer");

            }
            else if (computerChoice.equals("rock")) 
            {
                yourScore++;
                Winner = ("you");

            }
        }
        if (yourChoice.equals("scissors"))
        {
            if (computerChoice.equals("rock"))
            {
                computerScore ++;
                Winner = ("computer");

            }
            else if (computerChoice.equals("paper"))
            {
                yourScore++;
                Winner = ("you");

            }
        }
        if (!yourChoice.equals("rock||paper||scissors")) 
        {
            computerScore++;
            Winner = ("computer");

        }

        return Winner;
    }

    public void playRound()
    {
        printPrompt();
        String computerChoice=computerChoice();
        String userChoice=userChoice();
        System.out.println("You have chosen " + userChoice + " and the computer has chosen " + computerChoice);
        String findWinner = findWinner(computerChoice,userChoice);
        
        {
            if (findWinner.equals("draw"));
            System.out.println("This game is a draw");
            if (findWinner.equals("you"));
            System.out.println("You are the winner");
            if (findWinner.equals("computer"));
            System.out.println("The computer is the winner");
        }
        System.out.println("You have " + yourScore + "and the computer has "+ computerScore);
    }
}

Answer 1

if语句末尾的分号表示if语句为CONLETE。紧接在if语句之后的行是独立的，它们不属于if语句...这就是为什么它们总是运行。

改变：

if (findWinner.equals("draw"));
System.out.println("This game is a draw");

致：

if (findWinner.equals("draw"))
    System.out.println("This game is a draw");

或者更好：

if (findWinner.equals("draw")) {
    System.out.println("This game is a draw");
}

有没有什么建议可以帮我保存我最初的选择，这样我就不用一直输入了？

在findWinner（）中，您再次调用userChoice（）和computerChoirce（）。此时，这些值已经存在于传入的参数中，因此您不需要这些值。将其注释掉或删除：

public String findWinner(String yourChoice, String computerChoice) 
{
    // You don't need these two lines:
    //yourChoice = userChoice();
    //computerChoice = computerChoice(); 

    // ... other existing code ...
}

然后，在play圆桌会议（）中，调用printPrompt（）和userChoice（），它们都有自己的输入机制：

printPrompt();
String computerChoice=computerChoice();
String userChoice=userChoice();
System.out.println("You have chosen " + userChoice + " and the computer has chosen " + computerChoice);

我会去掉printPrompt（），然后做：

// printPrompt();
String computerChoice=computerChoice();
System.out.print("Enter your choice, paper, rock or scissors >"); 
String userChoice=userChoice();
System.out.println("You have chosen " + userChoice + " and the computer has chosen " + computerChoice);

findwiner（）中有一些逻辑错误。这并不像你想象的那样：

if (!yourChoice.equals("rock||paper||scissors")) 
{
    computerScore++;
    Winner = ("computer");
}

我认为你想做的是让计算机获胜，如果用户不输入“石头”、“纸”或“剪刀”？如果是这样，请将您的if语句更改为sterif语句，并添加最终的ster块：

public String findWinner(String yourChoice, String computerChoice) 
{
    String Winner = "";

    if (yourChoice.equals(computerChoice))
    {
        Winner = "draw";
    }
    else if (yourChoice.equals("rock")) 
    {
        if (computerChoice.equals("paper")) 
        {
            computerScore++;
            Winner = "computer";

        }
        else if (computerChoice.equals("scissors"))
        {
            yourScore++;
            Winner = "you";

        }
    }
    else if (yourChoice.equals("paper"))
    {
        if (computerChoice.equals("scissors"))
        {
            computerScore++;
            Winner = "computer";

        }
        else if (computerChoice.equals("rock")) 
        {
            yourScore++;
            Winner = "you";

        }
    }
    else if (yourChoice.equals("scissors"))
    {
        if (computerChoice.equals("rock"))
        {
            computerScore ++;
            Winner = "computer";

        }
        else if (computerChoice.equals("paper"))
        {
            yourScore++;
            Winner = "you";

        }
    }
    else // user did not type "rock", "paper", or "scissors"!
    {
        computerScore++;
        Winner = ("computer");

    }

    return Winner;
}

最后，主要的错误是，在调用findwiner（）时交换了参数的顺序。

改变：

String findWinner = findWinner(computerChoice, userChoice);

致：

String findWinner = findWinner(userChoice, computerChoice);

希望有帮助！