Veracode CWE ID 404资源关闭或释放不当

Question

我有这样的代码：

    try {
        BufferedWriter bw = null;
        FileWriter fw = null;
        try {
            final String fileName = getFileName();
            File propertiesFile=new File(getFilesDir(), fileName);
            fw = new FileWriter(propertiesFile);
            bw = new BufferedWriter(fw);
            bw.write(s);
            File file = new File(getFilesDir(), fileName);

        } catch (IOException e) {

        }finally{
            if(bw != null){
                bw.close();
            }
            if(fw != null){
                fw.close();
            }
            if(bw != null){
                bw.close();
            }
        }
    } catch (Exception e) {
    }

Veracode在这一行上检测到一个缺陷（不正确的资源关闭或释放）bw.write(s)；怎么解决这个？提前致谢

Answer 1

使用try finally修复缺陷，并在inside finally关闭BufferedWriter和FileWriter

   try {
    BufferedWriter bw = null;
    FileWriter fw = null;
    try {
        final String fileName = getFileName();
        File propertiesFile=new File(getFilesDir(), fileName);
        fw = new FileWriter(propertiesFile);
        bw = new BufferedWriter(fw);
        bw.write(s);
        File file = new File(getFilesDir(), fileName);

    }finally{
        if(bw != null){
            bw.close();
        }
        if(fw != null){
            fw.close();
        }
    }
} catch (Exception e) {
}