在调用另一个事务性方法的异步方法中回滚

Question

我有一个非事务性和异步方法，它调用同一服务的其他事务性方法。

如果发生了什么事情，我会捕获一个异常，如果发生了什么事情，我会保存错误，但回滚不起作用。

@Service
@Transactional(readOnly = true)
public class PlayerServiceImpl implements PlayerService {

    @Inject
    PlayerRepository playerRepository;

    @Override
    @Transactional(readOnly = false, propagation = Propagation.REQUIRED)
    public void save(PlayerEntity player) {
        //more code here
        playerRepository.save(player);
    }

    //other methods
}

    @Service
    public class TeamServiceImpl implements TeamService {

        @Inject
        TeamRepository teamRepository;

        @Inject
        MessageRepository messageRepository;

        @Inject
        ErrorRepository errorRepository;    

        @Inject
        PlayerService playerService;    


        @Async("asyncExecutor")
        @Override
        public void saveWithPlayersAsync(TeamEntity team, User user) {

            MessageEntity message = new MessageEntity();

            try {

    //I want rollback this if something wrong happens
                this.savePlayersA(team);
                this.savePlayersB(team);
                message.setContent("Ok !");
            } catch (TeamException e) {
                //e.printStackTrace();
                message.setContent("Fail !");           
                message.setUser(user)
//I save the error for audit
                errorRepository.save(new Error("Fail", user.getCode()));
            } finally {
//always save message for user than execute de function
                messageRepository.save(message);
            }

        }   

        @Transactional(readOnly = false, rollbackFor = TeamException.class)
        private void savePlayersA(TeamEntity team) throws TeamException {
            PlayerEntity p1 = new PlayerEntity();
            p1.setName("Name 1");
            p1.setSurname("Surname 1");
            p1.setTeam(team);
            playerService.save(p1);

            PlayerEntity p2 = new PlayerEntity();
            p2.setName("Name 2");
            p2.setSurname("Surname 2");
            p2.setTeam(team);
            playerService.save(p2);
        }

        @Transactional(readOnly = false, rollbackFor = TeamException.class)
        private void savePlayersB(TeamEntity team) throws TeamException {
            PlayerEntity p3 = new PlayerEntity();
            p3.setName("Name 3");
            p3.setSurname("Surname 3");
            p3.setTeam(team);
            playerService.save(p3);

            PlayerEntity p4 = new PlayerEntity();
            p4.setName("Name 4");
            p4.setSurname("Surname 4");
            p4.setTeam(team);
            playerService.save(p4);

            // here something happens and throw my custom exception
            if (true) {
                throw new TeamException("Fail!");
            }
        }   
    }

Answer 1

这不回滚的原因是因为调用事务性方法的异步方法在同一个类中。当您用@transaction或@Async注释方法时，注释代码由Spring创建的代理处理。当被注释的方法像这样在同一个类中时，对它们的调用不能被代理捕获以通过spring处理额外的请求，因此对方法的注释是多余的。您可以通过将savePlayer方法放在一个单独的类中，并在其中使用事务性方法来实现这一点。