对象计算验证C#

Question

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace Assignment_2
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        private void OrderButton_Click(object sender, EventArgs e)
        {
            double withTax = 0;
            double tax = 0;
            double subTotal = 0;
            var pizzas = new Pizza[3];
            if(ValidateAndDeclareQuantities())
            {
                pizzas = Declare();
                subTotal = CalcSubTotal(pizzas);
                tax = CalcTax(pizzas);
                withTax = CalcWithTax(pizzas);
            }

        }
        bool ValidateAndDeclareQuantities()
        {
            var combolist = new List<ComboBox>();
            combolist.Add(comboBox1);
            combolist.Add(comboBox2);
        combolist.Add(comboBox3);
        var textboxlist = new List<TextBox>();
        textboxlist.Add(Quantity1);
        textboxlist.Add(Quantity2);
        textboxlist.Add(Quantity3);
        for (int i = 0; i < 3; i++)
        {
            if (combolist[i].Text == "Cheese" || combolist[i].Text ==     "Vegetable" || combolist[i].Text == "Meat")
            { }
            else combolist[i].Text = "Wrong input";
        }
        int[] Quantities = new int[3];
        for (int i = 0; i < 3; i++)
        {
            if (int.TryParse(textboxlist[i].Text, out     Quantities[i])&&textboxlist[i].Text!=null)
            { }
            else { textboxlist[i].Text = "Wrong input"; }
        }
        return true;
    }

    Pizza[] Declare()
    {
        var pizzas = new Pizza[3];
        string type;
        int price;
        type = comboBox1.Text;
        price = int.Parse(Quantity1.Text);
        Pizza pizza1 = new Pizza(type, price);
        pizzas[0] = pizza1;

        type = comboBox2.Text;
        price = int.Parse(Quantity2.Text);
        Pizza pizza2 = new Pizza(type, price);
        pizzas[1] = pizza2;

        type = comboBox3.Text;
        price = int.Parse(Quantity3.Text);
        Pizza pizza3 = new Pizza(type, price);
        pizzas[2] = pizza3;

        return pizzas;
    }

    double CalcSubTotal(Pizza[] pizzas)
    {
        double subTotal = 0;
        for (int i = 0; i < 3; i++)
        {
            subTotal += pizzas[i].Price;
        }
        return subTotal;
    }

    double CalcTax(Pizza[] pizzas)
    {
        double tax = 0;
        for (int i = 0; i < 3; i++)
        {
            tax += pizzas[i].Tax;
        }
        return tax;
    }

    double CalcWithTax(Pizza[] pizzas)
    {
        double withTax = 0;
        for (int i = 0; i < 3; i++)
        {
            withTax += pizzas[i].WithTax;
        }
        return withTax;
    }

    void WriteOut(double subTotal, double tax, double withTax)
    {
        lblSubTotal.Text = "" + subTotal;
        lblTax.Text = "" + tax;
        lblTotal.Text = "" + withTax;
    }

    }
}

namespace Assignment_2
{
class Pizza
{
    string type;
    int quantity;
    public double Price;
    public double SubTotal;
    public double Tax;
    public double WithTax;
    public Pizza(string type, int quantity)
    {
        this.type = type;
        this.quantity = quantity;
        FindPrice();
        CalcSubTotal();
        CalcTax();
        CalcWithTax();
    }
    private void FindPrice()
    {
        switch (type)
        {
            case "Cheese":
                Price = 9.95;
                break;
            case "Vegetables":
                Price = 10.95;
                break;
            case "Meat":
                Price = 11.95;
                break;
        }
    }
    private void CalcSubTotal()
    {
        SubTotal = Price * quantity;
    }
    private void CalcTax()
    {
        Tax = SubTotal * 0.13;
    }
    private void CalcWithTax()
    {
       WithTax = SubTotal + Tax;
    }
}
}

Answer 1

答案很快：

>

validateanddeclareumantations从不html" target="_blank">返回false。当您设置“错误输入”时，它应该（可能）返回false。

（次要）Int[]数量=新Int[3]；除了给它写信，从来没有用过。

命名不需要特定类别的东西：比如奶酪比萨饼和火腿比萨饼。枚举是你的朋友！使用它们而不是像“cheese”这样的字符串：

public enum PizzaType{
    Cheese,
    Tomato
}

以这种方式使用枚举有助于避免意外的大写所带来的痛苦，而且速度也快得多。有奶酪披萨吗？

重复：代码的大部分也是重复的；你会想要尽可能多的练习避免它。('dry'/'don't'repeatyourself')。一点前瞻性的计划会有很大的帮助。每个人对代码结构都有偏好；我这里是一个单独的“Pizza Displayer”类，它包含一个数量输入框并进行验证。