是否可以编写简短的if语句[关闭]

Question

想改进这个问题吗 通过编辑此帖子，添加详细信息并澄清问题。

这是我的if语句。我只想写得更短。因为我认为这些是无效的。顺便说一句，每个if语句都是独立的。

for (int i = 0; i < count; i++) {

    if (js.getBoolean("[" + i + "].createdDate")) {
        String a = js.get("[" + i + "].createdDate").toString();
        Assert.assertTrue(a.matches(actual_createdDate));
    }
    if (js.getBoolean("[" + i + "].lastModifiedDate")) {
        String b = js.get("[" + i + "].lastModifiedDate").toString();
        Assert.assertTrue(b.matches(actual_modifiedDate));
    }
    if (js.getBoolean("[" + i + "].uuid")) {
        String c = js.get("[" + i + "].uuid").toString();
        Assert.assertTrue(c.matches(actual_uuid));
    }
    if (js.get("[" + i + "].coverPhoto") != null) {
        String d = response1.jsonPath().get("[" + i + "].coverPhoto.tempDownloadURL").toString();
        Assert.assertTrue(d.matches(actual_temp_url));
        System.out.println(js.get("[" + i + "].coverPhoto.tempDownloadURL").toString() + " is equalent to : " + actual_temp_url);
    }
    if (js.get("[" + i + "].coverPhoto.metadata['Thumbnail-Large']") != null) {
        String e = response1.jsonPath().get("[" + i + "].coverPhoto.metadata['Thumbnail-Large']").toString();
        Assert.assertTrue(e.matches(actual_metaData_url));
        System.out.println(js.get("[" + i + "].coverPhoto.metadata['Thumbnail-Large']").toString() + " is equalent to : " + actual_metaData_url);
    }

}

Answer 1

我改了，但有错

异常线程"main"java.lang.NullPointerException atio.restassured.path.json.JsonPath.getBoolean（JsonPath.java:214）at Album.assert等于（Album.java:240）at Album.main（Album.java:52）

private static void assertEqual(JsonPath js /*idk the type*/, int i, String fieldName, String expectedValue) {
    String property = "[" + i + "]." + fieldName;
    if (js.getBoolean(property)) {
        String value = js.get(property).toString();
        Assert.assertTrue(value.matches(expectedValue));
    }
}

和

for (int i = 0; i < count; i++) {
        assertEqual(js, i, "createdDate", actual_createdDate);
        assertEqual(js, i, "lastModifiedDate", actual_modifiedDate);
        assertEqual(js, i, "uuid", actual_uuid);
        assertEqual(js, i, "coverPhoto", actual_temp_url);
        assertEqual(js, i, "coverPhoto.metadata['Thumbnail-Large']", actual_metaData_url);
    }

Answer 2

请允许我向您介绍在怪人圈子中称为“函数”的一流代码重用单元；）

for (int i = 0; i < count; i++) {
    assertEqual(js, i, "createdDate", actual_createdDate);
    assertEqual(js, i, "lastModifiedDate", actual_modifiedDate);
    assertEqual(js, i, "uuid", actual_uuid);
    assertEqual(js, i, "coverPhoto", actual_temp_url);
    assertEqual(js, i, "coverPhoto.metadata['Thumbnail-Large']", actual_metaData_url);
}
    
private void assertEqual(JS js /*idk the type*/, int i, String fieldName, String expectedValue) {
    String property = "[" + i + "]." + fieldName;
    if (js.getBoolean(property)) {
        String value = js.get(property).toString();
        Assert.assertTrue(value.matches(expectedValue));
    }
}