如何窥探动态调用的函数

Question

我正在与Javascript、Mocha、Chai和SinonJ合作。我想做的是监视一个“equals”方法，该方法由另一个方法“compareUsingOperator”动态调用。下面的代码显示了我的类“StringComparator”，它有两个方法“equals”和“compareUsingOperator”。

export default class StringComparator {

    private compareFunctionList: {[key in "=" | "!=" | "<>" | "<" | "<=" | ">" | ">="]: Function};

    public constructor() {
        this.compareFunctionList = {
            "=" : this.equals,
            "!=" : this.notEquals,
            "<>" : this.notEquals,
            "<" : this.lessThan,
            "<=" : this.lessThanOrEquals,
            ">" : this.greaterThan,
            ">=" : this.greaterThanOrEquals,
        };
    }

    public equals(value1: string, value2: string): boolean {
        if (typeof value1 != "string" || typeof value2 != "string") {
            console.log(value1);
            console.log(value2);
            throw new TypeError("Invalid data type!");
        }

        return (value1 === value2);
    }

    public compareUsingOperator(operator: "=" | "!=" | "<>" | "<" | "<=" | ">" | ">=", value1: string, value2: string): boolean {
        if (typeof operator != "string" || typeof value1 != "string" || typeof value2 != "string") {
            throw new TypeError("Invalid data type!");
        }

        if (!Object.keys(this.compareFunctionList).includes(operator)) {
            throw new ReferenceError("Undefined operator!");
        }

        const fn: Function = this.compareFunctionList[operator];
        return fn.call(this, value1, value2);
    }

}

这是我的单元测试:

            describe("compareUsingOperator", () => {
                context("calls", () => {
                    comparator.validOperators.forEach((operator) => {
                        it("the proper function according to the given operator", () => {
                            sinon.spy(actual, "equals");

                            actual.compareUsingOperator("=", comparator.value1, comparator.value2);

                            assert.called(actual.equals);
                            actual.equals.restore();
                        });
                    });

                });
            });

在我的单元测试中，我在“equals”方法上设置了一个间谍，如下所示：

sinon.spy(actual, "equals");

“actual”是“StringComparator”的实例。

在下一步中，我将调用：

actual.compareUsingOperator("=", comparator.value1, comparator.value2);

在此方法中，执行以下代码：

const fn: Function = this.compareFunctionList[operator];
        return fn.call(this, value1, value2);

这是对“equals”方法的调用。这也是我的问题。我想知道是否调用了“equals”。我使用以下断言：

assert.called(actual.equals);

我从chai/sinon那里得到的答案是：

AssertError: expected equals to have been called at least once but was never called

预期行为应为绿色测试。

我的单元测试有什么问题？在控制台的帮助下.log我可以证明“等于”已经被调用了。

问候

弗洛里安

Answer 1

我自己找到了答案。我不得不替换：

   const fn: Function = this.compareFunctionList[operator];
   return fn.call(this, value1, value2);

使用:

    const fn: string = this.compareFunctionList[operator];
    return this[fn](value1, value2);

还有这个：

private compareFunctionList: {[key in "=" | "!=" | "<>" | "<" | "<=" | ">" | ">="]: Function};

    public constructor() {
        this.compareFunctionList = {
            "=" : this.equals,
            "!=" : this.notEquals,
            "<>" : this.notEquals,
            "<" : this.lessThan,
            "<=" : this.lessThanOrEquals,
            ">" : this.greaterThan,
            ">=" : this.greaterThanOrEquals,
        };
    }

像这样：

private compareFunctionList: {[key in "=" | "!=" | "<>" | "<" | "<=" | ">" | ">="]: string};

    public constructor() {
        this.compareFunctionList = {
            "=" : "equals",
            "!=" : "notEquals",
            "<>" : "notEquals",
            "<" : "lessThan"
            "<=" : "lessThanOrEquals",
            ">" : "greaterThan",
            ">=" : "greaterThanOrEquals",
        };
    }

现在该类是可测试的。

坦克和问候

弗洛里安