测试@service的ArchUnit规则只依赖于自己包中的@repository？

Question

我希望编写一个ArchUnit规则，验证服务类（由@serviceSpring注释所指出）只使用自己包中的存储库，而不使用其他包中的存储库。

noClasses().that()
  .areAnnotatedWith(Service.class)
  .should()
  .dependOnClassesThat().areAnnotatedWith(Repository.class)
  .orShould().dependOnClassesThat().haveSimpleNameEndingWith("Repository")

或者，我可以做：

noClasses().that()
  .resideInAPackage("com.company.backend.user")
  .and()
  .areAnnotatedWith(Service.class)
  .should()
  .dependOnClassesThat(resideOutsideOfPackage("com.company.backend.user").and(annotatedWith(Repository.class)))
  .orShould().dependOnClassesThat(have(resideOutsideOfPackage("com.company.backend.user").and(simpleNameEndingWith("Repository"))))
  .as("Service classes should only use Repository class(es) from the own package");

但是，我重复包名com.company.backend.user3次，我需要为每个包定义这个规则。

Answer 1

您需要在依赖项上定义一个谓词并对其进行操作。

classes()
    .that()
    .areAnnotatedWith(Service.class)
    .should(ArchConditions.onlyHaveDependenciesWhere(RepositoryAccessesAreOnlyWithinPackage.PREDICATE));

谓词检查访问目标是否是存储库，如果是，它将验证目标是否与调用类位于同一个包中：

private static class RepositoryAccessesAreOnlyWithinPackage
        extends DescribedPredicate<Dependency> {

    public static final DescribedPredicate<Dependency> PREDICATE = new RepositoryAccessesAreOnlyWithinPackage();

    public RepositoryAccessesAreOnlyWithinPackage() {
        super("repository accesses are only within the same package");
    }

    @Override
    public boolean apply(Dependency dependency) {
        if (isRepositoryAccess(dependency)) {
            return areClassesInTheSamePackage(dependency.getOriginClass(), dependency.getTargetClass());
        }

        return true;
    }

    private boolean isRepositoryAccess(Dependency dependency) {
        return dependency.getTargetClass().isAnnotatedWith(Repository.class);
    }

    private boolean areClassesInTheSamePackage(JavaClass originClass, JavaClass targetClass) {
        return originClass.getPackageName().equals(targetClass.getPackageName());
    }
}