我怎样才能更好地重写下面的Java代码呢？

Question

我有一小段Java密码。我想用一种更有建设性的方式和更优雅的方式重写下面的代码。我怎样才能实现它？

boolean ifJobTypeIsProfileAndAccountTypeIsNotInternal(PrimecastAccount primecastAccount,Job job) { 
if( job.getProfile() != null && job.getContactList() == null && job.getParameterisedContactList() == null) {
 return true;
} else if (job.getProfile() == null && job.getContactList() != null && job.getParameterisedContactList() == null) {
 return false;
} else if (job.getProfile() == null && job.getContactList() == null && job.getParameterisedContactList() != null) {
 return false;
} else if (job.getProfile() == null && job.getContactList() == null && job.getParameterisedContactList() == null) {
  log.error("Either a contact list, parameterised contact list or profile not found for the flight : {}", job );
  throw new RuntimeException("Either a contact list, parameterised contact list or profile not found for the flight");
} else {
  log.error("Found both contact list/parameterised list and profile for the flight : {}", job );
  throw new RuntimeException("Found both contact list/parameterised list and profile for the flight");
}

return true;

}

非常感谢您的帮助

Answer 1

如果您使用的是Java 8或更高版本，则可以使用流、对象#nonnull和对象#isnull

public boolean isProfileTypeJobWithNotInternalAccountType(Job job){
    var profile  = job.getProfile();
    var contList = job.getContactList();
    var paCoList = job.getParameterisedContactList();
    
    var allNull = Stream.of(profile,contList,paCoList).allMatch(Objects::isNull);
    var twoNotNull = Stream.of(profile,contList,paCoList).filter(Objects::nonNull).count() > 1;
    
    if(allNull){
        log.error("Either a contact list, parameterised contact list or profile not found for the flight : {}", job );
        throw new RuntimeException("Either a contact list, parameterised contact list or profile not found for the flight");
    }
    if(twoNotNull){            
        log.error("Found both contact list/parameterised list and profile for the flight : {}", job );
        throw new RuntimeException("Found both contact list/parameterised list and profile for the flight");
    }
    return Objects.nonNull(profile);
}