spring控制器catch块中的单元测试代码

Question

我有以下结构的控制器：

@RequestMapping(value = "${foo.controller.requestMappingUrl.login}", method = RequestMethod.POST)
    public ResponseMessage<String> loginUser(
            @RequestParam("username") String username, HttpServletRequest httpServletRequest,
            HttpServletResponse httpServletResponse) {

    try {

       return fooService.login(username); // can mock test

    } catch (UserNotFoundException e) {
            //CANNOT MOCK TEST THIS BLOCK
            String errorMsg = LoggerUtil.printStackTrace(e);
            LOG.error("[RequestId: {}] UserNotFoundException: {}, Stack: {}", requestId, e.getMessage(), errorMsg);
            httpServletResponse.setStatus(HttpStatus.NOT_ACCEPTABLE.value());
            statusCode = StatusCode.UserNotFound.value();
            responseMessage.buildResponseMessage(StringUtils.EMPTY, HttpStatus.NOT_ACCEPTABLE, statusCode,
                    messageByLocaleService.getMessageResponse(statusCode, null, locale));
    }
}

当我模拟抛出异常UserNotFoundException时，我只得到NestedServletException。即使我尝试添加expected=NestedServletException.class。corbetura报告指出测试中没有覆盖代码块。您有什么建议来帮助测试catch块内的代码吗。

请求的测试代码：

@SuppressWarnings("unchecked")
@Test(expected = UserNotFoundException.class)
    public void testControllerUserNotFoundException() throws Exception {
        Response resp = new Response();
        resp.setStatusCode(StatusCode.UserNotFoundErrorCode);
        when(fooService.login(any(String.class)).thenThrow(UserNotFoundException.class);

        mockMvc.perform(post("/service-user/1.0/auth/login?&username=test")
                        .contentType(contentType)).andExpect(status().isNotAcceptable())
                .andExpect(jsonPath("$.statusCode", is("ERRORCODE144")));

    }

和堆栈跟踪

Java.lang.exception：意外的异常，应该是在org.junit.internal.runners.statements.expectException.evaluate（expectException.Java:28)在org.junit.internal.runners.statements.runbefores.evaluate（expectException.Java:26)在org.springframework.test.context.junit4.statements.runbefores.evaluate（expectException.Java:26)在）在org.junit.runners.parentrunner.runchildres(Parentrunner.Java:288)在org.junit.runners.parentrunner.access$000(Parentrunner.Java:58)在org.junit.runners.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner.parentrunner在org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run（RemoteTestRunner.java:390)处运行（RemoteTestRunner.main（RemoteTestRunner.java:197)，原因为：org.springframework.web.util.NestedServletException：请求处理失败；嵌套异常是com.atlassian.crowd.exception.runtime.usernotfoundexception（位于org.springframework.web.servlet.frameworkservlet.processrequest（位于org.springframework.web.servlet.frameworkservlet.processrequest：982））（位于org.springframework.web.servlet.frameworkservlet.doPost（位于org.springframework.web.servlet.framework.doPost）（位于AccessorImpl.Invoke0（本机方法）在Sun.Reflect.NativeMethodAccessorImpl.Invoke(NativeMethodAccessorImpl.java:62)在Sun.Reflect.DelegatingMethodAccessorImpl.Invoke(DelegatingMethodAccessorImpl.Invoke:43)在java.lang.Reflect.Method.Invoke:498)在org.junit.Runners.Model.FrameworkMethod$1.RunReflectiveCall(FrameworkMethod.50)在

Answer 1

您不能期望controller方法出现UserNotFoundException异常，因为您只是通过日志记录并返回带有ErrorCode144的响应来抑制它。

这里的最佳实践是配置controlleradvice，以便可以全局处理所有异常，并且您的控制器看起来很干净，如下所示，我建议您也看看这里关于spring控制器的异常处理。

ExceptionControllerAdvice类：

@ControllerAdvice
public class ExceptionControllerAdvice {

    @ExceptionHandler(UserNotFoundException.class)
    public ResponseEntity<String> handleUnexpectedException(UnexpectedException 
                     unExpectedExe) {

        //log and send the response back to the client here
    }
}

控制器方法：

@RequestMapping(value = "${foo.controller.requestMappingUrl.login}",
                                 method = RequestMethod.POST)
public ResponseMessage<String> loginUser(
            @RequestParam("username") String username,
               HttpServletRequest httpServletRequest,
               HttpServletResponse httpServletResponse) {

       return fooService.login(username);
}

JUnit设置和测试方法：

@Before
    public void setUp() throws Exception {
        MockitoAnnotations.initMocks(this);
    mockMvc = MockMvcBuilders.standaloneSetup(projectController)
                .setMessageConverters(new MappingJackson2HttpMessageConverter())
                .setControllerAdvice(new ExceptionControllerAdvice()).build();
}


@SuppressWarnings("unchecked")
@Test
    public void testControllerUserNotFoundException() throws Exception {
        Response resp = new Response();
        resp.setStatusCode(StatusCode.UserNotFoundErrorCode);
        when(fooService.login(any(String.class)).
        thenThrow(UserNotFoundException.class);
        mockMvc.perform(post("/service-user/1.0/auth/login?&username=test")
                        .contentType(contentType)).
     andExpect(status().isNotAcceptable())
                .andExpect(jsonPath("$.statusCode", is("ERRORCODE144")));
}