使用when(methodX).ThenReturn(resultY)，是否调用了methodX？

Question

我有一些困难嘲弄一些单元测试的必要依赖。我怀疑我没有正确理解如何使用Mockito when（）.ThenReturn（）。

下面是我要测试的服务的代码部分（希望是相关的）：

@Singleton
public class AppointmentService {
    private DataConnector connector;

    @Inject
    public AppointmentService(DataConnector connector) {
        this.connector = connector;
    }

    public Appointment getAppointment(UriInfo uriInfo, String id) {
        HttpResponse response = connector.getAppointment(id);
        return validateResponse(response, uriInfo);
    }

    protected Appointment validateResponse(HttpResponse response, UriInfo uriInfo) {
        try {
            AppointmentWrapper appointmentWrapper = JacksonJsonUtility.readValue(response.getInputStream(), AppointmentWrapper.class);
            if(appointmentWrapper.getAppointment()!=null) {
                return appointmentConverterHelper(appointmentWrapper.getAppointment(), uriInfo.getPath());
            }
        } catch(IOException e) {
            throw new ResponseParsingException("IOException: " + e.getMessage());
        }
    }

    protected Appointment appointmentConverterHelper(ExternalAppointmentModel appointmentDto, String uriPath) {
        if (appointmentDto == null) {
            throw new BrickworkQueryException("Got an invalid appointment object from Brickwork!");
        }

        Customer customer = new Customer(new Name(appointmentDto.getCustomer().getName()),
            appointmentDto.getCustomer().getEmail(),
            String.valueOf(appointmentDto.getCustomer().getCode()));

        return new Appointment(
            appointmentDto.getId(),
            customer);
    }

}

我的理解是，这个方法的单元测试应该如下所示：

public class AppointmentServiceTest {

    private UriInfo mockUriInfo;
    private HttpResponse mockHttpResponse;

    @Mock
    private DataConnector mockDataConnector;

    @InjectMocks
    private AppointmentService appointmentService;

    @Before
    public void setUp() throws Exception {
        MockitoAnnotations.initMocks(this);
        mockUriInfo();
        mockHttpResponse();
    }

    private void mockUriInfo() {
        mockUriInfo = mock(UriInfo.class);
        when(mockUriInfo.getRequestUri()).thenReturn(
            URI.create("http://localhost:8080"));
    }

    private void mockHttpResponse() {
        mockHttpResponse = mock(HttpResponse.class);
        when(mockHttpResponse.getInputStream()).thenReturn(
            IOUtils.toInputStream("{\"appointment\":{}}"));
    }

    @Test
    public void testGetAppointment() throws Exception {
        when(mockDataConnector.getAppointmentById(Mockito.anyString())).
            thenReturn(mockHttpResponse);
        when(appointmentService.validateResponse(Mockito.any(HttpResponse.class), Mockito.any(UriInfo.class))).
            thenReturn(new Appointment());
        appointmentService.getAppointment(mockUriInfo, "12345");
        verify(mockDataConnector).getAppointment(Mockito.anyString());
    }
}

当我运行测试时，在尝试调用appointmentTo.getCustomer（）时，在appointmentConverterHelper方法中得到一个NullPointerException（可以理解为空）。由于代码现在正在运行，在我看来，我将需要在我的mockHttpResponse中返回一个包含完全有效约会的InputStream。既然我有when(appointmentService.validateresponse（mockHttpResponse,mockUriInfo））.thenreturn（new Appointment（））；难道不应该调用validateresponse并返回空的Appointment对象而不是实际运行validateresponse吗？

这里是AppointmentServiceTest的exception-line 140的堆栈跟踪是上面的when语句，以供参考。AppointmentsService的第176行是JacksonJsonUtility.ReadValue(response.GetInputStream(),appointmentWrapper.Class)；ValidateResponse方法开头的行：

java.lang.NullPointerException
    at com.nike.appointmentservice.service.AppointmentsService.validatedResponse(AppointmentsService.java:176)
    at com.nike.appointmentservice.service.AppointmentsServiceTest.testGetAppointmentById(AppointmentsServiceTest.java:140)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)```

Answer 1

基于这篇文章，我认为监视AppointmentService是允许我模拟validateresponse调用的方法。下面是我的测试现在的样子：

public class AppointmentServiceTest {

    private UriInfo mockUriInfo;
    private HttpResponse mockHttpResponse;

    @Mock
    private DataConnector mockDataConnector;

    @Spy
    private AppointmentsService appointmentsServiceSpy;

    @InjectMocks
    private AppointmentService appointmentService;

    @Before
    public void setUp() throws Exception {
        MockitoAnnotations.initMocks(this);
        appointmentsServiceSpy = spy(appointmentsService);
        mockUriInfo();
        mockHttpResponse();
    }

    private void mockUriInfo() {
        mockUriInfo = mock(UriInfo.class);
        when(mockUriInfo.getRequestUri()).thenReturn(
            URI.create("http://localhost:8080"));
    }

    private void mockHttpResponse() {
        mockHttpResponse = mock(HttpResponse.class);
        when(mockHttpResponse.getInputStream()).thenReturn(
            IOUtils.toInputStream("{\"appointment\":{}}"));
    }

    @Test
    public void testGetAppointment() throws Exception {
        when(mockDataConnector.getAppointmentById(Mockito.anyString())).
            thenReturn(mockHttpResponse);
        doReturn(new Appointment()).when(appointmentsServiceSpy).validateResponse(Mockito.any(HttpResponse.class), Mockito.any(UriInfo.class));
        appointmentServiceSpy.getAppointment(mockUriInfo, "12345");
        verify(mockDataConnector).getAppointmentById(Mockito.anyString());
    }
}

我仍然在实际的appointmentServicespy.getappointment调用中遇到一个异常，但我认为这是一个与如何使用间谍有关的单独问题。就原问题而言，使用带有doReturn().when()语句的spy可以解决使用when().thenReturn()语句时错误调用方法的问题。

Answer 2

我认为问题可能是when语句试图与特定实例匹配，但失败了。要开始使用Mockito单元测试，您应该将when语句中的特定值替换为表示“anything”的Mockito占位符。例如：

when(mockDataConnector.getAppointmentById(Mockito.anyString())).
  thenReturn(mockHttpResponse);

when(appointmentService.validateResponse(Mockito.any(HttpResponse.class), Mockito.any(UriInfo.class))).
        thenReturn(new Appointment());

当基本单元测试工作时，就可以添加更具体的单元测试。

更新

我现在注意到，您正在尝试测试appointmentService类，但同时也在模拟该类中的validateresponsehtml" target="_blank">方法。作为一个Mockito专家，我还不足以知道这是否完全不正确，但这不是我在单元测试中使用Mockito的方式。我正在测试的类根本没有被嘲弄，而是模拟它调用的类，以便模拟变量行为，并查看被测试类如何响应。

我认为您可能需要模拟JacksonJsonUtility类（powermock帮助处理静态类），并删除ValidateResponse方法上的模拟。您将需要构造JacksonJsonUtility.ReadValue方法的模拟响应，以便它包含AppointmentService类所需的所有内容。