Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treatment of Ambiguous Column #657

Closed
sqlalchemy-bot opened this issue Jul 15, 2007 · 2 comments
Closed

treatment of Ambiguous Column #657

sqlalchemy-bot opened this issue Jul 15, 2007 · 2 comments
Labels
bug Something isn't working engine engines, connections, transactions, isolation levels, execution options low priority
Milestone

Comments

@sqlalchemy-bot
Copy link
Collaborator

Migrated issue, originally created by Anonymous

in engine\base.py

if self.__props.setdefault(colname.lower(), rec) is not rec:
self.__propscolname.lower() = (ResultProxy.AmbiguousColumn(colname), 0)

sets the __props entry for ambiguous column to be the above, which breaks the code in various places where a three tuple is expected

ammending the above to be
if self.__props.setdefault(colname.lower(), rec) is not rec:
type = ResultProxy.AmbiguousColumn(colname)
self.__propscolname.lower() = (type, type.dialect_impl(self.dialect), i)

will cause appropriate exception to be thrown when ambiguous columns are accessed.

@sqlalchemy-bot
Copy link
Collaborator Author

Michael Bayer (@zzzeek) wrote:

changeset:2915

@sqlalchemy-bot
Copy link
Collaborator Author

Changes by Michael Bayer (@zzzeek):

  • changed status to closed

@sqlalchemy-bot sqlalchemy-bot added bug Something isn't working low priority engine engines, connections, transactions, isolation levels, execution options labels Nov 27, 2018
@sqlalchemy-bot sqlalchemy-bot added this to the 0.3.9 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engine engines, connections, transactions, isolation levels, execution options low priority
Projects
None yet
Development

No branches or pull requests

1 participant